Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20869] Create DomainParticipantExtendedQos class #4779

Merged
merged 8 commits into from
Jun 24, 2024
Merged

[20869] Create DomainParticipantExtendedQos class #4779

merged 8 commits into from
Jun 24, 2024
+279 −3

Conversation

LuciaEchevarria99
Copy link
Contributor

@LuciaEchevarria99 LuciaEchevarria99 commented May 14, 2024 •
edited by EduPonz
Loading

Create DomainParticipantExtendedQos class

This PR creates the DomainParticipantExtendedQos class, which extends the functionality of the existing DomainParticipantQos class by adding the domainId member. It also updates the DomainParticipantFactory to support the creation of participants using DomainParticipantExtendedQos.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are ABI compatible.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Related documentation PR: eProsima/Fast-DDS-docs# [20869] Add documentation for DomainParticipantExtendedQos Fast-DDS-docs#805
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@LuciaEchevarria99 LuciaEchevarria99 added this to the v3.0.0 milestone May 14, 2024
@LuciaEchevarria99 LuciaEchevarria99 changed the title Feature/extended qos Create DomainParticipantExtendedQos class May 14, 2024
This was referenced May 16, 2024
Merged
Closed
@elianalf elianalf added the needs-review PR that is ready to be reviewed label May 20, 2024
@LuciaEchevarria99 LuciaEchevarria99 mentioned this pull request May 20, 2024
Merged
@EduPonz EduPonz changed the title Create DomainParticipantExtendedQos class [20869] Create DomainParticipantExtendedQos class May 27, 2024
elianalf
elianalf suggested changes May 28, 2024
View reviewed changes
Copy link
Contributor

@elianalf elianalf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to include also a small section in Fast DDS docs in Profile based creation of a DomainParticipant and an example in the Profile based creation of a DomainParticipant

I think that you can complete the Contributor Checklist as follow:

  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

src/cpp/fastdds/utils/QosConverters.hpp Show resolved Hide resolved
src/cpp/fastdds/domain/DomainParticipantFactory.cpp Show resolved Hide resolved
include/fastdds/dds/domain/DomainParticipantFactory.hpp Outdated Show resolved Hide resolved
include/fastdds/dds/domain/qos/DomainParticipantExtendedQos.hpp Show resolved Hide resolved
include/fastdds/dds/domain/qos/DomainParticipantExtendedQos.hpp Outdated Show resolved Hide resolved
test/unittest/dds/participant/ParticipantTests.cpp Show resolved Hide resolved
test/unittest/dds/participant/ParticipantTests.cpp Show resolved Hide resolved
test/unittest/dds/participant/ParticipantTests.cpp Show resolved Hide resolved
test/unittest/dds/participant/ParticipantTests.cpp Outdated Show resolved Hide resolved
test/unittest/dds/participant/ParticipantTests.cpp Outdated Show resolved Hide resolved
@elianalf elianalf removed the needs-review PR that is ready to be reviewed label May 30, 2024
@elianalf elianalf self-requested a review June 4, 2024 12:29
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 4, 2024
@elianalf elianalf requested review from elianalf and removed request for elianalf June 5, 2024 10:33
@LuciaEchevarria99 LuciaEchevarria99 mentioned this pull request Jun 6, 2024
Merged
7 tasks
@LuciaEchevarria99 LuciaEchevarria99 mentioned this pull request Jun 18, 2024
Merged
@elianalf elianalf requested review from elianalf and removed request for elianalf June 18, 2024 09:28
@LuciaEchevarria99 LuciaEchevarria99 mentioned this pull request Jun 19, 2024
Merged
7 tasks
@LuciaEchevarria99 LuciaEchevarria99 force-pushed the feature/extended_qos branch 2 times, most recently from 59b340e to 4638341 Compare June 19, 2024 13:05
@elianalf elianalf requested review from elianalf and removed request for elianalf June 19, 2024 14:42
@LuciaEchevarria99
Create DomainParticipantExtendedQos
7663e94 
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
@LuciaEchevarria99
Apply suggested changes
9959cee 
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
@LuciaEchevarria99
Check uncrustify
7fa515a 
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
@LuciaEchevarria99
Remove default_participant_extended_qos_
441ccb4 
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
@LuciaEchevarria99
Remove unnecessary domain_id in CreateDomainParticipantWithExtendedQo…
60fa17d 
…sFromProfile test

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
@LuciaEchevarria99
Fix uncrustify
3631bed 
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
@LuciaEchevarria99
Update versions.md
f4bb27c 
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
@LuciaEchevarria99 LuciaEchevarria99 requested review from elianalf and removed request for elianalf June 24, 2024 06:58
@LuciaEchevarria99
Fix versions.md
f1f16ac 
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
@LuciaEchevarria99 LuciaEchevarria99 requested review from elianalf and removed request for elianalf June 24, 2024 07:03
@EduPonz EduPonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jun 24, 2024
@EduPonz EduPonz merged commit 869fee3 into master Jun 24, 2024
22 of 31 checks passed
@EduPonz EduPonz deleted the feature/extended_qos branch June 24, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz left review comments

@elianalf elianalf elianalf approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@LuciaEchevarria99 @EduPonz @elianalf